linux-kernel - Re: [PATCH] kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAS73Or9G82-8zT=7XjKfP_zEK2+TgutaOHw7SPeeO9_CA@mail.gmail.com>
Date:   Mon, 21 Aug 2017 18:04:38 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Thierry Reding <treding@...dia.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Bjørn Forsman <bjorn.forsman@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Michal Marek <mmarek@...e.com>, linux-pm@...r.kernel.org,
        Kieran Bingham <kieran@...gham.xyz>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Renninger <trenn@...e.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jan Kiszka <jan.kiszka@...mens.com>
Subject: Re: [PATCH] kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd)

2017-08-21 17:49 GMT+09:00 Thierry Reding <treding@...dia.com>:
> On Sun, Aug 20, 2017 at 03:04:11PM +0900, Masahiro Yamada wrote:
>> Kbuild conventionally uses $(shell cd ... && /bin/pwd) idiom to get
>> the absolute path of the directory because GNU Make 3.80, the minimal
>> supported version at that time, did not support $(abspath ...) or
>> $(realpath ...).
>>
>> Commit 37d69ee30808 ("docs: bump minimal GNU Make version to 3.81")
>> dropped the GNU Make 3.80 support, so we are now allowed to use those
>> make-builtin helpers.
>>
>> This conversion will provide better portability without relying on
>> the pwd command or its location /bin/pwd.
>>
>> I am intentionally using $(realpath ...) instead $(abspath ...) in
>> some places.  The difference between the two is $(realpath ...)
>> returns an empty string if the given path does not exist.  It is
>> convenient in places where we need to error-out if the makefile fails
>> to create an output directory.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> ---
>>
>>  Makefile                       | 12 ++++++------
>>  scripts/gdb/linux/Makefile     |  2 +-
>>  tools/power/cpupower/Makefile  |  2 +-
>>  tools/scripts/Makefile.include |  6 +++---
>>  4 files changed, 11 insertions(+), 11 deletions(-)
>
> This looks very similar to a patch I had written a long time ago:
>
> Acked-by: Thierry Reding <treding@...dia.com>


Yup.

Three month ago, I sent a reminder to you,
but I did not get a response.

https://lkml.org/lkml/2017/5/18/1370




This time, Bjorn sent a patch to replace /bin/pwd with pwd.

I asked him to use $(abspath ...) / $(realpath ...),
but he did not like to do it.

https://patchwork.kernel.org/patch/9859591/


So, I am doing it by myself.



-- 
Best Regards
Masahiro Yamada