linux-kernel - Re: [PATCH] kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 1 Sep 2017 08:52:21 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Thierry Reding <treding@...dia.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Bjørn Forsman <bjorn.forsman@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Michal Marek <mmarek@...e.com>, linux-pm@...r.kernel.org,
        Kieran Bingham <kieran@...uared.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Renninger <trenn@...e.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jan Kiszka <jan.kiszka@...mens.com>
Subject: Re: [PATCH] kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd)

2017-08-21 18:04 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> 2017-08-21 17:49 GMT+09:00 Thierry Reding <treding@...dia.com>:
>> On Sun, Aug 20, 2017 at 03:04:11PM +0900, Masahiro Yamada wrote:
>>> Kbuild conventionally uses $(shell cd ... && /bin/pwd) idiom to get
>>> the absolute path of the directory because GNU Make 3.80, the minimal
>>> supported version at that time, did not support $(abspath ...) or
>>> $(realpath ...).
>>>
>>> Commit 37d69ee30808 ("docs: bump minimal GNU Make version to 3.81")
>>> dropped the GNU Make 3.80 support, so we are now allowed to use those
>>> make-builtin helpers.
>>>
>>> This conversion will provide better portability without relying on
>>> the pwd command or its location /bin/pwd.
>>>
>>> I am intentionally using $(realpath ...) instead $(abspath ...) in
>>> some places.  The difference between the two is $(realpath ...)
>>> returns an empty string if the given path does not exist.  It is
>>> convenient in places where we need to error-out if the makefile fails
>>> to create an output directory.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>

Applied to linux-kbuild.