linux-kernel - Re: [PATCH v3 2/7] pwm: rockchip: Remove the judge from return value of pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f3bda8e-3130-efeb-92f4-f6c57944b1f3@rock-chips.com>
Date:   Mon, 21 Aug 2017 19:29:00 +0800
From:   "David.Wu" <david.wu@...k-chips.com>
To:     Brian Norris <briannorris@...omium.org>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     heiko@...ech.de, boris.brezillon@...e-electrons.com,
        robh+dt@...nel.org, catalin.marinas@....com, dianders@...omium.org,
        mark.rutland@....com, huangtao@...k-chips.com,
        linux-pwm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/7] pwm: rockchip: Remove the judge from return value
 of pwm_config

Hi Thierry,

在 2017/8/19 0:28, Brian Norris 写道:
> On Fri, Aug 18, 2017 at 05:32:55PM +0200, Thierry Reding wrote:
>> I don't understand what the "judge" is supposed to be, but I've applied
>> this to for-4.14/drivers anyway. Thanks.
> 
> Probably just an artifact of non-native English.
> 
> Judging by context, David probably meant more like "Remove the check for
> the return value". I believe I've seen other non-native English speakers
> use "judge" in a way similar to "check" or "test" in the context of
> comparisons and error checking. (A search through my mailbox for "judge"
> confirms this.)
> 

Yeap, as Brain said, the "Remove the check for the return value "will be 
better, the "judge" looks like a grammatical error here now.

> Regards,
> Brian
> 
> 
>