linux-kernel - Re: [PATCH v7 3/4] lib/cmdline.c Remove quotes symmetrically.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170821133003.1855fc4e@kitsune.suse.cz>
Date:   Mon, 21 Aug 2017 13:30:03 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Baoquan He <bhe@...hat.com>
Cc:     linux-doc@...r.kernel.org, Lokesh Vutla <lokeshvutla@...com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        David Howells <dhowells@...hat.com>,
        Sylvain 'ythier' Hitier <sylvain.hitier@...il.com>,
        Paul Mackerras <paulus@...ba.org>,
        Hari Bathini <hbathini@...ux.vnet.ibm.com>,
        Ingo Molnar <mingo@...nel.org>,
        Michael Neuling <mikey@...ling.org>,
        Jonathan Corbet <corbet@....net>,
        Ilya Matveychikov <matvejchikov@...il.com>,
        Mahesh J Salgaonkar <mahesh@...ux.vnet.ibm.com>,
        Thiago Jung Bauermann <bauerman@...ux.vnet.ibm.com>,
        Kees Cook <keescook@...omium.org>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Scott Wood <oss@...error.net>, Jason Baron <jbaron@...mai.com>,
        "Steven Rostedt, " <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Daniel Axtens <dja@...ens.net>, linux-kernel@...r.kernel.org,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
        Jessica Yu <jeyu@...nel.org>, Tejun Heo <tj@...nel.org>,
        Oliver O'Halloran <oohall@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v7 3/4] lib/cmdline.c Remove quotes symmetrically.

On Mon, 21 Aug 2017 18:27:12 +0800
Baoquan He <bhe@...hat.com> wrote:

> On 08/17/17 at 10:14pm, Michal Suchanek wrote:
> > Remove quotes from argument value only if there is qoute on both
> > sides.
> > 
> > Signed-off-by: Michal Suchanek <msuchanek@...e.de>  
> 
> Sounds reasonable. Just for curiosity, do we have chance to pass in
> option with a single '"'?

No, we don't. Perhaps it would work if it was at the end of the
commandline.

next_arg checks that quoting is closed.

It was possible but undocumented with previous behavior - you would
place the quote in the middle and the closing quote at start or end so
that next_arg would remove the closing quote but not the one in the
middle.

It would be also possible with shell-like backslash escaping but that
is not implemented.

Thanks

Michal