linux-kernel - Re: [PATCH] quota_v2: Delete an error message for a failed memory allocation in v2_read_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170821140349.GA31870@quack2.suse.cz>
Date:   Mon, 21 Aug 2017 16:03:49 +0200
From:   Jan Kara <jack@...e.cz>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Jan Kara <jack@...e.com>, kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] quota_v2: Delete an error message for a failed memory
 allocation in v2_read_file_info()

On Wed 16-08-17 16:41:00, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 16 Aug 2017 16:16:30 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

OK, applied the patch to my tree. Thanks.

								Honza

> ---
>  fs/quota/quota_v2.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/quota/quota_v2.c b/fs/quota/quota_v2.c
> index ca71bf881ad1..2259329616b7 100644
> --- a/fs/quota/quota_v2.c
> +++ b/fs/quota/quota_v2.c
> @@ -109,11 +109,9 @@ static int v2_read_file_info(struct super_block *sb, int type)
>  		return -1;
>  	}
>  	info->dqi_priv = kmalloc(sizeof(struct qtree_mem_dqinfo), GFP_NOFS);
> -	if (!info->dqi_priv) {
> -		printk(KERN_WARNING
> -		       "Not enough memory for quota information structure.\n");
> +	if (!info->dqi_priv)
>  		return -ENOMEM;
> -	}
> +
>  	qinfo = info->dqi_priv;
>  	if (version == 0) {
>  		/* limits are stored as unsigned 32-bit data */
> -- 
> 2.14.0
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR