linux-kernel - Re: [PATCH 1/2] video: fbdev: Fix multiple style issues in xilinxfb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <2014067.suSortcy05@amdc3058>
Date:   Mon, 21 Aug 2017 16:04:14 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu,
        Hyun Kwon <hyun.kwon@...inx.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        linux-fbdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] video: fbdev: Fix multiple style issues in xilinxfb

On Tuesday, August 08, 2017 10:10:25 AM Michal Simek wrote:
> From: Hyun Kwon <hyun.kwon@...inx.com>
> 
> All reported by from checkpatch
> ./scripts/checkpatch.pl --max-line-length 120 -strict -f
> drivers/video/fbdev/xilinxfb.c
> 
> WARNING: Block comments should align the * on each line
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Block comments use * on subsequent lines
> WARNING: please, no space before tabs
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> WARNING: braces {} are not necessary for single statement blocks
> WARNING: Missing a blank line after declarations
> WARNING: struct of_device_id should normally be const
> CHECK: Please don't use multiple blank lines
> CHECK: Blank lines aren't necessary after an open brace '{'
> CHECK: Alignment should match open parenthesis
> CHECK: 'Endianess' may be misspelled - perhaps 'Endianness'?
> CHECK: spaces preferred around that '*' (ctx:VxV)
> ERROR: that open brace { should be on the previous line
> 
> Signed-off-by: Hyun Kwon <hyun.kwon@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

Patch queued for 4.14, thanks.
 
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics