linux-kernel - Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 20 Aug 2017 22:44:51 -0700
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     "arm@...nel.org" <arm@...nel.org>, Arnd Bergmann <arnd@...db.de>
Cc:     Keerthy <j-keerthy@...com>, ssantosh@...nel.org,
        m-karicheri2@...com, t-kristo@...com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in
 knav_pool_create

Hi Arnd,

On 7/30/17 9:31 PM, Keerthy wrote:
> knav_pool_create is an exported function. In the event of a call
> before knav_queue_probe, we encounter a NULL pointer dereference
> in the following line. Hence return -EPROBE_DEFER to the caller till
> the kdev pointer is non-NULL.
> 
> Signed-off-by: Keerthy <j-keerthy@...com>
> ---
> 
> Changes in v2:
> 
>    * Fixed returning an int to returning pointer.
FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>

Can you please also apply this fix in your fixes branch ?