linux-kernel - Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2Jg7Sor57jQ2Q2cOozAP1G=o3=ZR2qFDsP_dFRSKy9bg@mail.gmail.com>
Date:   Mon, 21 Aug 2017 09:21:05 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
Cc:     "arm@...nel.org" <arm@...nel.org>, Keerthy <j-keerthy@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Murali Karicheri <m-karicheri2@...com>,
        Tero Kristo <t-kristo@...com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create

On Mon, Aug 21, 2017 at 7:44 AM, santosh.shilimkar@...cle.com
<santosh.shilimkar@...cle.com> wrote:
> Hi Arnd,
>
> On 7/30/17 9:31 PM, Keerthy wrote:
>>
>> knav_pool_create is an exported function. In the event of a call
>> before knav_queue_probe, we encounter a NULL pointer dereference
>> in the following line. Hence return -EPROBE_DEFER to the caller till
>> the kdev pointer is non-NULL.
>>
>> Signed-off-by: Keerthy <j-keerthy@...com>
>> ---
>>
>> Changes in v2:
>>
>>    * Fixed returning an int to returning pointer.
>
> FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>
>
> Can you please also apply this fix in your fixes branch ?

Applied now, thanks!

      Arnd