linux-kernel - Re: [PATCH 0/4] constify scsi/tty parisc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12d14a03-5734-9b97-fff0-f8fe7158ce63@gmx.de>
Date:   Mon, 21 Aug 2017 22:43:39 +0200
From:   Helge Deller <deller@....de>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, gregkh@...uxfoundation.org,
        jslaby@...e.com
Cc:     linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH 0/4] constify scsi/tty parisc_device_id

On 19.08.2017 19:54, Arvind Yadav wrote:
> parisc_device_id are not supposed to change at runtime. All functions
> working with parisc_device_id provided by <asm/parisc-device.h> work with
> const parisc_device_id. So mark the non-const structs as const.
> 
> Arvind Yadav (4):
>   [PATCH 1/4] scsi: lasi700: constify parisc_device_id
>   [PATCH 2/4] scsi: zalon: constify parisc_device_id
>   [PATCH 3/4] tty: 8250: constify parisc_device_id
>   [PATCH 4/4] tty: mux: constify parisc_device_id

NAK.
Please don't apply.
I have other patches in my tree which will move those consts
into __init sections instead.

Thanks,
Helge

 
>  drivers/scsi/lasi700.c             | 2 +-
>  drivers/scsi/zalon.c               | 2 +-
>  drivers/tty/serial/8250/8250_gsc.c | 4 ++--
>  drivers/tty/serial/mux.c           | 4 ++--
>  4 files changed, 6 insertions(+), 6 deletions(-)
>