linux-kernel - Re: [PATCH] sched/fair: move definitions to fix !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170821204438.GI23807@destiny>
Date:   Mon, 21 Aug 2017 16:44:39 -0400
From:   Josef Bacik <josef@...icpanda.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     josef@...icpanda.com, linux-kernel@...r.kernel.org,
        kernel-team@...com, Josef Bacik <jbacik@...com>
Subject: Re: [PATCH] sched/fair: move definitions to fix !CONFIG_SMP

On Mon, Aug 21, 2017 at 10:06:53PM +0200, Peter Zijlstra wrote:
> On Mon, Aug 21, 2017 at 04:03:05PM -0400, josef@...icpanda.com wrote:
> > From: Josef Bacik <jbacik@...com>
> > 
> > The series of patches adding runnable_avg and subsequent supporting
> > patches broke on !CONFIG_SMP.  Fix this by moving the definitions under
> > the appropriate checks, and moving the !CONFIG_SMP definitions higher
> > up.
> 
> Is this on top or can I fold this in somewhere? I was meaning to rework
> the series to avoid this superfluous build borkage.

There's actually a lot of individual breakages.  I can go through and make
individual patches that can be folded in to where they were introduced, or I can
do them all at once.  There's breakage around !CONFIG_FAIR_GROUP_SCHED as well,
basically everything you added needs to be moved around some.  I'll do whatever
is most convenient for you.  Thanks,

Josef