linux-kernel - Re: [PATCH v2 1/3] dt-bindings: add eeprom "size" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170822091107.uubxhwilkutduou7@valkosipuli.retiisi.org.uk>
Date:   Tue, 22 Aug 2017 12:11:07 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Divagar Mohandass <divagar.mohandass@...el.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, wsa@...-dreams.de,
        devicetree@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, rajmohan.mani@...el.com
Subject: Re: [PATCH v2 1/3] dt-bindings: add eeprom "size" property

Hi Divagar,

On Tue, Aug 15, 2017 at 12:11:57AM +0530, Divagar Mohandass wrote:
> This adds eeprom "size" as optional property for i2c eeproms.
> 
> "size" should be mentioned in byte and it should refer
> to the eeprom size. This will be read by the driver and
> used to calculating the number of bytes in read/write calls.

Instead of the three lines above, how about:

The "size" property allows explicitly specifying the size of the EEPROM
chip in bytes.

> 
> Signed-off-by: Divagar Mohandass <divagar.mohandass@...el.com>
> ---
>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index 5696eb5..1436569 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -32,6 +32,8 @@ Optional properties:
>  
>    - read-only: this parameterless property disables writes to the eeprom
>  
> +  - size: total eeprom size in bytes
> +
>  Example:
>  
>  eeprom@52 {
> -- 
> 1.9.1
> 

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@....fi