lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Aug 2017 12:13:22 +0300 From: Sakari Ailus <sakari.ailus@....fi> To: Divagar Mohandass <divagar.mohandass@...el.com> Cc: robh+dt@...nel.org, mark.rutland@....com, wsa@...-dreams.de, devicetree@...r.kernel.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, rajmohan.mani@...el.com Subject: Re: [PATCH v2 2/3] eeprom: at24: add support to fetch eeprom device property "size" Hi Divagar, On Tue, Aug 15, 2017 at 12:11:58AM +0530, Divagar Mohandass wrote: > This adds support to fetch device property "size" from _DSD. > > There is a CAT24C16/GT24C16S NVMEM chip part of the OV13858 > camera module and it is connected to i2c bus on Intel KBL board. > This device will use the existing ACPI ID INT3499 and platform > fw will expose "read-only", "pagesize" and "size" props via _DSD. Instead of the two paragraphs, how about: Obtain the size of the EEPROM chip from DT if the "size" property is specified for the device. > > Signed-off-by: Divagar Mohandass <divagar.mohandass@...el.com> > --- > drivers/misc/eeprom/at24.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > index 764ff5df..2199c42 100644 > --- a/drivers/misc/eeprom/at24.c > +++ b/drivers/misc/eeprom/at24.c > @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct at24_platform_data *chip) > if (device_property_present(dev, "read-only")) > chip->flags |= AT24_FLAG_READONLY; > > + err = device_property_read_u32(dev, "size", &val); > + if (!err) > + chip->byte_len = val; > + > err = device_property_read_u32(dev, "pagesize", &val); > if (!err) { > chip->page_size = val; > -- > 1.9.1 > -- Sakari Ailus e-mail: sakari.ailus@....fi
Powered by blists - more mailing lists