linux-kernel - Re: [PATCH] virt/kvm avoids oops by adding parameter checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad18fd18-e58c-bc70-6660-e05ddbb232a9@redhat.com>
Date:   Tue, 22 Aug 2017 15:37:15 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     nixiaoming <nixiaoming@...wei.com>, rkrcmar@...hat.com
Cc:     kvm@...r.kernel.org, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virt/kvm avoids oops by adding parameter checking

On 22/08/2017 03:09, nixiaoming wrote:
> The error parameter passed through the external interface causes the system oops.
> So it is necessary to increase the parameter check for all EXPORT_SYMBOL_GPL
> 
> example:
>  void kvm_get_kvm(struct kvm *kvm)
>  {
>         refcount_inc(&kvm->users_count); /*oops if kvm == NULL */
>  }
>  EXPORT_SYMBOL_GPL(kvm_get_kvm);
> 
> Signed-off-by: nixiaoming <nixiaoming@...wei.com>

No.  It's simply a precondition that kvm != NULL in this case.

Paolo