linux-kernel - Re: [PATCH] CPUFREQ: Loongson2: constify platform_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1667536.6Dg5FN45O3@aspire.rjw.lan>
Date:   Tue, 22 Aug 2017 15:30:33 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] CPUFREQ: Loongson2: constify platform_device_id

On Wednesday, August 16, 2017 5:25:59 AM CEST Viresh Kumar wrote:
> On 13-08-17, 15:10, Arvind Yadav wrote:
> > platform_device_id are not supposed to change at runtime. All functions
> > working with platform_device_id provided by <linux/platform_device.h>
> > work with const platform_device_id. So mark the non-const structs as
> > const.
> > 
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> > ---
> >  drivers/cpufreq/loongson2_cpufreq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
> > index 9ac27b2..da34469 100644
> > --- a/drivers/cpufreq/loongson2_cpufreq.c
> > +++ b/drivers/cpufreq/loongson2_cpufreq.c
> > @@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = {
> >  	.attr = cpufreq_generic_attr,
> >  };
> >  
> > -static struct platform_device_id platform_device_ids[] = {
> > +static const struct platform_device_id platform_device_ids[] = {
> >  	{
> >  		.name = "loongson2_cpufreq",
> >  	},
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> 
> 

Applied, thanks!