linux-kernel - Re: [PATCH][next] efi/reboot: make function pointer orig_pm_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKv+Gu98+6mJhn9KxHvtQ5LQdgmtc2Yd4LBJjK=ds91AGX4o9Q@mail.gmail.com>
Date:   Tue, 22 Aug 2017 17:32:40 +0100
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Matt Fleming <matt@...eblueprint.co.uk>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] efi/reboot: make function pointer orig_pm_power_off static

On 22 August 2017 at 16:50, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The function pointer orig_pm_power_off is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'orig_pm_power_off' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Queued, thanks.

> ---
>  drivers/firmware/efi/reboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/reboot.c b/drivers/firmware/efi/reboot.c
> index 7117e2d0c7f9..22874544d301 100644
> --- a/drivers/firmware/efi/reboot.c
> +++ b/drivers/firmware/efi/reboot.c
> @@ -5,7 +5,7 @@
>  #include <linux/efi.h>
>  #include <linux/reboot.h>
>
> -void (*orig_pm_power_off)(void);
> +static void (*orig_pm_power_off)(void);
>
>  int efi_reboot_quirk_mode = -1;
>
> --
> 2.14.1
>