linux-kernel - Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc07e4ee-0477-c91e-29f9-68d1792341de@broadcom.com>
Date:   Wed, 23 Aug 2017 09:20:15 -0700
From:   James Smart <james.smart@...adcom.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: remove useless code in
 lpfc_sli4_bsg_link_diag_test

On 8/22/2017 1:53 PM, Gustavo A. R. Silva wrote:
> Remove variable assignments. The value stored in local variable _rc_ is
> overwritten at line 2448:rc = lpfc_sli4_bsg_set_link_diag_state(phba, 0);
> before it can be used.
>
> Addresses-Coverity-ID: 1226935
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
> This issue was detected by Coverity and it was tested by compilation only.
> Notice that this code has been there since 2011.
>
>   drivers/scsi/lpfc/lpfc_bsg.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
>
>

looks good. Thanks

Signed-off-by: James Smart <james.smart@...adcom.com>

-- james