linux-kernel - Re: [PATCH] seccomp: add missing semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLfUb72SxcLyXysimX-ra25L0ZmfekAZYnakioZkZEWJQ@mail.gmail.com>
Date:   Wed, 23 Aug 2017 09:20:41 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Arnd Bergmann <arnd@...db.de>, James Morris <jmorris@...ei.org>
Cc:     Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>,
        Tyler Hicks <tyhicks@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] seccomp: add missing semicolon

On Wed, Aug 23, 2017 at 6:43 AM, Arnd Bergmann <arnd@...db.de> wrote:
> We get a compile error without it, at least in some configurations:
>
> kernel/seccomp.c:1221:1: error: expected ',' or ';' at end of input
>
> Fixes: 8e5f1ad116df ("seccomp: Sysctl to display available actions")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Oh, how completely strange. I never saw this in my build testing. If
you have the .config that tripped this, please let me know.

James, can you take this for -next please?

Acked-by: Kees Cook <keescook@...omium.org>

Thanks!

-Kees

> ---
>  kernel/seccomp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/seccomp.c b/kernel/seccomp.c
> index c24579dfa7a1..3eeb2257bd62 100644
> --- a/kernel/seccomp.c
> +++ b/kernel/seccomp.c
> @@ -1218,6 +1218,6 @@ static int __init seccomp_sysctl_init(void)
>         return 0;
>  }
>
> -device_initcall(seccomp_sysctl_init)
> +device_initcall(seccomp_sysctl_init);
>
>  #endif /* CONFIG_SYSCTL */
> --
> 2.9.0
>



-- 
Kees Cook
Pixel Security