linux-kernel - Re: [PATCH] seccomp: add missing semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab69c59e-0c20-6f40-0c8d-d3e5db970f44@canonical.com>
Date:   Wed, 23 Aug 2017 11:38:06 -0500
From:   Tyler Hicks <tyhicks@...onical.com>
To:     Kees Cook <keescook@...omium.org>, Arnd Bergmann <arnd@...db.de>
Cc:     James Morris <jmorris@...ei.org>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] seccomp: add missing semicolon

On 08/23/2017 11:20 AM, Kees Cook wrote:
> On Wed, Aug 23, 2017 at 6:43 AM, Arnd Bergmann <arnd@...db.de> wrote:
>> We get a compile error without it, at least in some configurations:
>>
>> kernel/seccomp.c:1221:1: error: expected ',' or ';' at end of input
>>
>> Fixes: 8e5f1ad116df ("seccomp: Sysctl to display available actions")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Oh, how completely strange. I never saw this in my build testing. If
> you have the .config that tripped this, please let me know.

Same here...

Thanks for the fix, Arnd!

Tyler

> 
> James, can you take this for -next please?
> 
> Acked-by: Kees Cook <keescook@...omium.org>
> 
> Thanks!
> 
> -Kees
> 
>> ---
>>  kernel/seccomp.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/seccomp.c b/kernel/seccomp.c
>> index c24579dfa7a1..3eeb2257bd62 100644
>> --- a/kernel/seccomp.c
>> +++ b/kernel/seccomp.c
>> @@ -1218,6 +1218,6 @@ static int __init seccomp_sysctl_init(void)
>>         return 0;
>>  }
>>
>> -device_initcall(seccomp_sysctl_init)
>> +device_initcall(seccomp_sysctl_init);
>>
>>  #endif /* CONFIG_SYSCTL */
>> --
>> 2.9.0
>>
> 
> 
> 




Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)