linux-kernel - Re: [PATCH] mfd: omap-usb-tll: fix register offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170824084623.54d3iim56yqvgc4z@dell>
Date:   Thu, 24 Aug 2017 09:46:23 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Tony Lindgren <tony@...mide.com>, Roger Quadros <rogerq@...com>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: omap-usb-tll: fix register offsets

On Wed, 23 Aug 2017, Arnd Bergmann wrote:

> gcc-8 notices that the register number calculation is wrong
> when the offset is an 'u8' but the number is larger than 256:
> 
> drivers/mfd/omap-usb-tll.c: In function 'omap_tll_init':
> drivers/mfd/omap-usb-tll.c:90:46: error: overflow in conversion from 'int' to 'u8 {aka unsigned char}' chages value from 'i * 256 + 2070' to '22' [-Werror=overflow]
> 
> This addresses it by always using a 32-bit offset number for
> the register. This is apparently an old problem that previous
> compilers did not find.
> 
> Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mfd/omap-usb-tll.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog