linux-kernel - Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h60ddj7l8.wl-tiwai@suse.de>
Date:   Thu, 24 Aug 2017 17:42:11 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Tom Rini <trini@...sulko.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
        Liam Girdwood <lgirdwood@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bard Liao <bardliao@...ltek.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

On Thu, 24 Aug 2017 16:41:52 +0200,
Tom Rini wrote:
> 
> On Thu, Aug 24, 2017 at 04:31:25PM +0200, Takashi Iwai wrote:
> > On Thu, 24 Aug 2017 16:28:29 +0200,
> > Takashi Iwai wrote:
> > > 
> > > On Thu, 24 Aug 2017 02:05:25 +0200,
> > > Tom Rini wrote:
> > > > 
> > > > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > > > 
> > > > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > > > > Not all devices with ACPI and this combination of sound devices will
> > > > > > > have the required information provided via ACPI.  Reintroduce the I2C
> > > > > > > device ID to restore sound functionality on on the Chromebook 'Samus'
> > > > > > > model.
> > > > > > 
> > > > > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > > > > that's not running ChromeOS).  My fault for getting out of the habit
> > > > > > > of
> > > > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm not
> > > > > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > > > > test
> > > > > > > my hardware here, and this does fix my laptop.
> > > > > > 
> > > > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data
> > > > > > in the module sources") does not fix your issue?
> > > > > 
> > > > > As that's not in master yet I can't tell.  Can you give me a pointer to
> > > > > somewhere?  Thanks!
> > > > 
> > > > OK, my bad, it has a different hash upstream,
> > 
> > BTW, the hash above is correct.  It's in Mark's asoc tree (and in
> > linux-next).  You might have cherry-picked a wrong one, I suppose?
> 
> Alright, I read-things to quickly, and to be clear:
> (a) "ASoC: rt5677: Hide platform data in the module sources" is _not_ in
> Linus' tree (I confused this with a different commit) and _is_ in Mark's
> ASoC for-next branch currently.
> (b) Applying just that patch on top of Linus' tree _does_ fix my
> regression (an Oops and non-functional audio) with audio and now sound
> works well, as expected.
> 
> Can we please get that as a fix for this release?  Thanks!

OK, so the fix for 4.13 would be either to cherry-pick this commit, or
just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
fix (and remove again in 4.14).

The former is cleaner, but it's bigger, while the latter is a safer
oneliner at the late RC stage.

I leave the decision to Mark.


Takashi