lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Aug 2017 14:23:19 -0400 From: Alex Deucher <alexdeucher@...il.com> To: Christian König <christian.koenig@....com> Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, "Deucher, Alexander" <alexander.deucher@....com>, Dave Airlie <airlied@...ux.ie>, "monk.liu" <Monk.Liu@....com>, Chunming Zhou <David1.Zhou@....com>, Alex Xie <AlexBin.Xie@....com>, Junwei Zhang <Jerry.Zhang@....com>, Dave Airlie <airlied@...hat.com>, Marek Olšák <marek.olsak@....com>, John Brooks <john@...tquake.com>, Andres Rodriguez <andresx7@...il.com>, Huang Rui <ray.huang@....com>, kernel-janitors@...r.kernel.org, Maling list - DRI developers <dri-devel@...ts.freedesktop.org>, amd-gfx list <amd-gfx@...ts.freedesktop.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drm/amdgpu: check memory allocation failure On Wed, Aug 23, 2017 at 4:39 AM, Christian König <christian.koenig@....com> wrote: > Am 23.08.2017 um 07:52 schrieb Christophe JAILLET: >> >> Check memory allocation failure and return -ENOMEM in such a case. >> >> 'num_post_dep_syncobjs' still has to be set to 0 before the test in order >> to have it initialized if 'amdgpu_cs_parser_fini()' is called to free >> resources. >> >> The calling graph would be, in such a case! >> failure in amdgpu_cs_process_syncobj_out_dep() >> ---> error code returned by amdgpu_cs_dependencies() >> --> amdgpu_cs_parser_fini() is called >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > > > Reviewed-by: Christian König <christian.koenig@....com> Applied. thanks! Alex > >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c >> index 15d4a28d73bb..baa90df90aea 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c >> @@ -1079,6 +1079,9 @@ static int amdgpu_cs_process_syncobj_out_dep(struct >> amdgpu_cs_parser *p, >> GFP_KERNEL); >> p->num_post_dep_syncobjs = 0; >> + if (!p->post_dep_syncobjs) >> + return -ENOMEM; >> + >> for (i = 0; i < num_deps; ++i) { >> p->post_dep_syncobjs[i] = drm_syncobj_find(p->filp, >> deps[i].handle); >> if (!p->post_dep_syncobjs[i]) > > > > _______________________________________________ > dri-devel mailing list > dri-devel@...ts.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists