linux-kernel - Re: [PATCH][drm-next] drm/amdgpu: remove duplicate return statement

Open Source and information security mailing list archives

Message-ID: <CADnq5_MyECf9zUr6eA2haDri=99usgmTZeV6zTD3TpZe6BnzKQ@mail.gmail.com>
Date:   Thu, 24 Aug 2017 14:26:11 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Felix Kuehling <felix.kuehling@....com>
Cc:     Colin King <colin.king@...onical.com>,
        Oded Gabbay <oded.gabbay@...il.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][drm-next] drm/amdgpu: remove duplicate return statement

On Wed, Aug 23, 2017 at 2:24 PM, Felix Kuehling <felix.kuehling@....com> wrote:
> I must have added that accidentally when cherry-picking an internal
> patch for upstreaming. Thanks for catching it.
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@....com>

Applied.  thanks!

Alex

>
> Regards,
>   Felix
>
>
> On 2017-08-23 09:17 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Remove a redundant identical return statement, it has no use.
>>
>> Detected by CoverityScan, CID#1454586 ("Structurally dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
>> index fb6e5dbd5a03..309f2419c6d8 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
>> @@ -155,7 +155,6 @@ static const struct kfd2kgd_calls kfd2kgd = {
>>  struct kfd2kgd_calls *amdgpu_amdkfd_gfx_8_0_get_functions(void)
>>  {
>>       return (struct kfd2kgd_calls *)&kfd2kgd;
>> -     return (struct kfd2kgd_calls *)&kfd2kgd;
>>  }
>>
>>  static inline struct amdgpu_device *get_amdgpu_device(struct kgd_dev *kgd)
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives