linux-kernel - Re: [PATCH] irqdomain: check for NULL before dereferencing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Aug 2017 10:45:15 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Dan Carpenter <dan.carpenter@...cle.com>
cc:     Marc Zyngier <marc.zyngier@....com>,
        David Daney <david.daney@...ium.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] irqdomain: check for NULL before dereferencing

On Fri, 25 Aug 2017, Dan Carpenter wrote:

> I reversed these two checks so we check "root_irq_data" for NULL before
> dereferencing it.

Can you please start to write coherent changelogs? See
Documentation/process/submitting-patches.rst

The above describes the change you made which is completely pointless
because we can see the change in the patch.

What's missing is WHY this is required and WHAT the problem with the
existing code is.

Thanks,

	tglx

> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index b9c688944429..e84b7056bb08 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -1505,10 +1505,10 @@ int irq_domain_push_irq(struct irq_domain *domain, int virq, void *arg)
>  	if (WARN_ON(!irq_domain_is_hierarchy(domain)))
>  		return -EINVAL;
>  
> -	if (domain->parent != root_irq_data->domain)
> +	if (!root_irq_data)
>  		return -EINVAL;
>  
> -	if (!root_irq_data)
> +	if (domain->parent != root_irq_data->domain)
>  		return -EINVAL;
>  
>  	child_irq_data = kzalloc_node(sizeof(*child_irq_data), GFP_KERNEL,
>