linux-kernel - Re: [PATCH] powerpc: powernv: Fix build error on const discarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h8wwv3nb.fsf@concordia.ellerman.id.au>
Date:   Fri, 25 Aug 2017 11:26:32 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Corentin Labbe <clabbe.montjoie@...il.com>
Cc:     benh@...nel.crashing.org, paulus@...ba.org,
        anju@...ux.vnet.ibm.com, maddy@...ux.vnet.ibm.com,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc: powernv: Fix build error on const discarding

Corentin Labbe <clabbe.montjoie@...il.com> writes:

> On Thu, Aug 17, 2017 at 10:52:11PM +1000, Michael Ellerman wrote:
>> Corentin Labbe <clabbe.montjoie@...il.com> writes:
>> 
>> > When building a random powerpc kernel I hit this build error:
>> >   CC      arch/powerpc/platforms/powernv/opal-imc.o
>> > arch/powerpc/platforms/powernv/opal-imc.c: In function « disable_nest_pmu_counters »:
>> > arch/powerpc/platforms/powernv/opal-imc.c:130:13: error : assignment discards « const » qualifier from pointer target type [-Werror=discarded-qualifiers]
>> >    l_cpumask = cpumask_of_node(nid);
>> >              ^
>> > This patch simply add const to l_cpumask to fix this issue.
>> 
>> Thanks. I'm not sure why we haven't seen that.
>> 
>> Do you mind attaching your .config ?
>> 
>> cheers
>
> Yes

Thanks.

So the key is:

> CONFIG_PPC_POWERNV=y
...
> # CONFIG_NUMA is not set


Which none of our configs have.

I'll add a test build of that.

Thanks.

cheers