linux-kernel - Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest integration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170825150916.GA353@infradead.org>
Date:   Fri, 25 Aug 2017 08:09:16 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Thayer <michael.thayer@...cle.com>,
        "Knut St . Osmundsen" <knut.osmundsen@...cle.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest
 integration

On Fri, Aug 25, 2017 at 05:06:52PM +0200, Hans de Goede wrote:
> I'm afraid that the userspace API is more or less a take it
> or leave it kinda deal, we can do small cleanups, but an
> entire re-design is out of the question. The vboxguest code
> has a long (too long) out of tree history and the same ioctl
> interface is used by VirtualBox upstream on Windows, Mac OS X,
> the BSDs and Solaris, so we cannot just go and break it to
> out hart's content.

Then hard out NAK for the code.