linux-kernel - Re: [PATCH] tpm_tis: make array cmd_getticks static const to shink object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170825173120.l2mp4tckdtyixzii@linux.intel.com>
Date:   Fri, 25 Aug 2017 20:31:20 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:     Colin King <colin.king@...onical.com>,
        Peter Huewe <peterhuewe@....de>,
        Marcel Selhorst <tpmdd@...horst.net>,
        tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm_tis: make array cmd_getticks static const to shink
 object code size

On Fri, Aug 25, 2017 at 10:52:42AM -0600, Jason Gunthorpe wrote:
> On Fri, Aug 25, 2017 at 05:45:05PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > Don't populate array cmd_getticks on the stack, instead make it static
> > const.  Makes the object code smaller by over 160 bytes:
> > 
> > Before:
> >    text	   data	    bss	    dec	    hex	filename
> >   18813	   3152	    128	  22093	   564d	drivers/char/tpm/tpm_tis_core.o
> > 
> > After:
> >    text	   data	    bss	    dec	    hex	filename
> >   18554	   3248	    128	  21930	   55aa	drivers/char/tpm/tpm_tis_core.o
> > 
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Reviewed-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
> 
> Jason

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

/Jarkko