linux-kernel - Re: [PATCH] tpm_tis: make array cmd_getticks static const to shink object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170906113149.ygsyk7rv4iwileks@linux.intel.com>
Date:   Wed, 6 Sep 2017 14:31:49 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Peter Huewe <peterhuewe@....de>,
        Marcel Selhorst <tpmdd@...horst.net>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm_tis: make array cmd_getticks static const to shink
 object code size

On Fri, Aug 25, 2017 at 05:45:05PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate array cmd_getticks on the stack, instead make it static
> const.  Makes the object code smaller by over 160 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   18813	   3152	    128	  22093	   564d	drivers/char/tpm/tpm_tis_core.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   18554	   3248	    128	  21930	   55aa	drivers/char/tpm/tpm_tis_core.o
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/char/tpm/tpm_tis_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index 63bc6c3b949e..1e957e923d21 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -445,7 +445,7 @@ static int probe_itpm(struct tpm_chip *chip)
>  {
>  	struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
>  	int rc = 0;
> -	u8 cmd_getticks[] = {
> +	static const u8 cmd_getticks[] = {
>  		0x00, 0xc1, 0x00, 0x00, 0x00, 0x0a,
>  		0x00, 0x00, 0x00, 0xf1
>  	};
> -- 
> 2.14.1
> 

Applied.

/Jarkko