linux-kernel - Re: [PATCH 3.16 119/134] ipv4: restore rt->fi for reference counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1503707590.3688.64.camel@decadent.org.uk>
Date:   Sat, 26 Aug 2017 01:33:10 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        WANG Cong <xiyou.wangcong@...il.com>
Subject: Re: [PATCH 3.16 119/134] ipv4: restore rt->fi for reference counting

On Fri, 2017-08-18 at 06:53 -0700, Eric Dumazet wrote:
> > On Fri, Aug 18, 2017 at 6:13 AM, Ben Hutchings <ben@...adent.org.uk> wrote:
> > 3.16.47-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: WANG Cong <xiyou.wangcong@...il.com>
> > 
> > commit 82486aa6f1b9bc8145e6d0fa2bc0b44307f3b875 upstream.
[...]
> I thought we refined this later with :

In fact it was reverted upstream, then replaced by the commits you
point out.  Thanks; I don't know why I missed that.

> commit 3fb07daff8e99243366a081e5129560734de4ada
> Author: Eric Dumazet <edumazet@...gle.com>
> Date:   Thu May 25 14:27:35 2017 -0700
> 
>     ipv4: add reference counting to metrics
[...]

It's not obvious how to backport this, as it adds:

+#define DST_METRICS_REFCOUNTED		0x2UL

but 3.16 already has a flag with value 2.  I don't think we can take
another bit from the pointer as metrics are only 32-bit aligned.

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that there are so many of
them.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)