linux-kernel - Re: [PATCH 1/9] ASoC: max98927: Added TDM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170827140238.bqav6pkpxd2yogch@sirena.org.uk>
Date:   Sun, 27 Aug 2017 15:02:38 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Ryan Lee <ryans.lee@...imintegrated.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        kuninori.morimoto.gx@...esas.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, ryan.lee.maxim@...il.com
Subject: Re: [PATCH 1/9] ASoC: max98927: Added TDM support

On Fri, Aug 25, 2017 at 05:41:02PM -0700, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@...imintegrated.com>

This says it's adding support for TDM mode but...

> +	case SND_SOC_DAIFMT_DSP_A:
> +		format = MAX98927_PCM_FORMAT_TDM_MODE1;
> +		break;
> +	case SND_SOC_DAIFMT_DSP_B:
> +		format = MAX98927_PCM_FORMAT_TDM_MODE0;
> +		break;
>  	case SND_SOC_DAIFMT_PDM:
> -		max98927->iface |= SND_SOC_DAIFMT_PDM;
> +		use_pdm = true;
>  		break;

...it looks like it's adding support for two new DSP modes and generally
making a bunch of other changes.  This probably needs splitting up, or
at least a bit more of a changelog.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)