linux-kernel - RE: [PATCH 1/9] ASoC: max98927: Added TDM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR11MB083775428D2A7EBE6D9D0725E79E0@BY2PR11MB0837.namprd11.prod.outlook.com>
Date:   Mon, 28 Aug 2017 23:34:41 +0000
From:   Ryan Lee <RyanS.Lee@...imintegrated.com>
To:     Mark Brown <broonie@...nel.org>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "kuninori.morimoto.gx@...esas.com" <kuninori.morimoto.gx@...esas.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ryan.lee.maxim@...il.com" <ryan.lee.maxim@...il.com>
Subject: RE: [PATCH 1/9] ASoC: max98927: Added TDM support

>Subject: Re: [PATCH 1/9] ASoC: max98927: Added TDM support
>
>On Fri, Aug 25, 2017 at 05:41:02PM -0700, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <mailto:ryans.lee@...imintegrated.com>
>
>This says it's adding support for TDM mode but...
>
>> +	case SND_SOC_DAIFMT_DSP_A:
>> +		format = MAX98927_PCM_FORMAT_TDM_MODE1;
>> +		break;
>> +	case SND_SOC_DAIFMT_DSP_B:
>> +		format = MAX98927_PCM_FORMAT_TDM_MODE0;
>> +		break;
>>  	case SND_SOC_DAIFMT_PDM:
>> -		max98927->iface |= SND_SOC_DAIFMT_PDM;
>> +		use_pdm = true;
>>  		break;
>
>...it looks like it's adding support for two new DSP modes and generally making a
>bunch of other changes.  This probably needs splitting up, or at least a bit more
>of a changelog.

I wanted to split this patch but changes were all about DSP_A and DSP_B format support.
I added more description about this patch and send patch series again.