[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3b89ad70-7024-b4ac-bf4e-49a02d12da51@gmail.com>
Date: Sun, 27 Aug 2017 13:01:15 +0200
From: Jacek Anaszewski <jacek.anaszewski@...il.com>
To: Andrew Jeffery <andrew@...id.au>
Cc: Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
rpurdie@...ys.net, robh+dt@...nel.org, mark.rutland@....com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
joel@....id.au, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown
Hi Andrew,
On 08/25/2017 09:32 AM, Pavel Machek wrote:
> On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:
>> In some systems, such as BMCs, we want to retain the state of LEDs
>> across a reboot of the BMC whilst the host remains up.
>
> I'd spell out what BMC is...
I agree with Pavel. Please give the expansion of the acronym
in both DT patch and the driver commit message.
>
> Otherwise series looks good.
>
> Acked-by: Pavel Machek <pavel@....cz>
--
Best regards,
Jacek Anaszewski
Powered by blists - more mailing lists