lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Aug 2017 09:30:19 +0930
From: Andrew Jeffery <andrew@...id.au>
To: Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc: Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
rpurdie@...ys.net, robh+dt@...nel.org, mark.rutland@....com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
joel@....id.au, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown
Hi Jacek, Pavel
On Sun, 2017-08-27 at 13:01 +0200, Jacek Anaszewski wrote:
> Hi Andrew,
>
> On 08/25/2017 09:32 AM, Pavel Machek wrote:
> > On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:
> > > In some systems, such as BMCs, we want to retain the state of LEDs
> > > across a reboot of the BMC whilst the host remains up.
> >
> > I'd spell out what BMC is...
>
> I agree with Pavel. Please give the expansion of the acronym
> in both DT patch and the driver commit message.
No worries, will reword and resend.
Thanks for the review.
Andrew
>
> >
> > Otherwise series looks good.
> >
> > Acked-by: Pavel Machek <pavel@....cz>
>
>
Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)
Powered by blists - more mailing lists