linux-kernel - Re: [PATCH] acpi/processor: make function acpi_processor_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Aug 2017 22:57:50 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Colin King <colin.king@...onical.com>
Cc:     Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acpi/processor: make function acpi_processor_check_duplicates static

On Tuesday, August 15, 2017 11:46:30 AM CEST Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The function acpi_processor_check_duplicates is local to the source and
> does not need to be in global scope, so make it static.
> 
> Cleans up sparse warnings:
> symbol 'acpi_processor_check_duplicates' was not declared. Should it
> be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/acpi/acpi_processor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
> index f098e25b6b41..86c10599d9f8 100644
> --- a/drivers/acpi/acpi_processor.c
> +++ b/drivers/acpi/acpi_processor.c
> @@ -670,7 +670,7 @@ static acpi_status __init acpi_processor_ids_walk(acpi_handle handle,
>  
>  }
>  
> -void __init acpi_processor_check_duplicates(void)
> +static void __init acpi_processor_check_duplicates(void)
>  {
>  	/* check the correctness for all processors in ACPI namespace */
>  	acpi_walk_namespace(ACPI_TYPE_PROCESSOR, ACPI_ROOT_OBJECT,
> 

Applied, thanks!