linux-kernel - Re: connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11fc2d4e-bcf4-9a1c-6d73-2e67aab2a1ed@users.sourceforge.net>
Date:   Mon, 28 Aug 2017 09:09:18 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Peter Waskiewicz Jr <peter.waskiewicz.jr@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Evgeniy Polyakov <zbr@...emap.net>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: connector: Delete an error message for a failed memory allocation
 in cn_queue_alloc_callback_entry()

> Did coccinelle trip on the message

I suggest to reconsider this implementation detail with the combination
of a function call like “kzalloc”.
A script for the semantic patch language can point various update candidates
out according to a source code search pattern which is similar to “OOM_MESSAGE”
in the script “checkpatch.pl”.

> or the fact you weren't returning NULL?

How does this concern fit to my update suggestion?

Regards,
Markus