linux-kernel - Re: module: Remove const attribute from alias for MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJMbS5ModDVhgs2kzus71B7pwkDd+GtvDZ=zjHDTmGNiQ@mail.gmail.com>
Date:   Mon, 28 Aug 2017 10:41:01 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Stefan Agner <stefan@...er.ch>, Jessica Yu <jeyu@...nel.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rusty Russell <rusty@...tcorp.com.au>,
        LKML <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <mmarek@...e.com>, Arnd Bergmann <arnd@...db.de>,
        Doug Anderson <dianders@...omium.org>,
        Grant Grundler <grundler@...omium.org>,
        Greg Hackmann <ghackmann@...gle.com>,
        Michael Davidson <md@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Bernhard.Rosenkranzer@...aro.org
Subject: Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE

On Mon, Aug 28, 2017 at 10:38 AM, Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
> I think Kees' proposal is a better solution; rather than require all
> usage of device table to remember to add const, have the macro add it
> for all users.  Otherwise if you require caller's to add it, they may
> forget.

And with the coccinelle script, it should be easy to invert the logic
and remove const from the callers...

-Kees

-- 
Kees Cook
Pixel Security