linux-kernel - Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeoEk0SA=0w=BN-3Q0L+GaOb9Zh=xnrPrAKrKqLYcCz4g@mail.gmail.com>
Date:   Mon, 28 Aug 2017 20:44:21 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Borislav Petkov <bp@...e.de>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Tyler Baicar <tbaicar@...eaurora.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, Will Deacon <will.deacon@....com>,
        james.morse@....com, shiju.jose@...wei.com,
        Geliang Tang <geliangtang@...il.com>,
        Tony Luck <tony.luck@...el.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3] acpi: apei: clear error status before acknowledging
 the error

On Mon, Aug 28, 2017 at 8:25 PM, Borislav Petkov <bp@...e.de> wrote:
> On Mon, Aug 28, 2017 at 08:20:37PM +0300, Andy Shevchenko wrote:
>>        if (rc != -ENOENT && is_hest_type_generic_v2(ghes))
>>  :-)
>>
>> But again, your call to choose :-)
>
> Slow down please.
>
> What do you think is more readable: a compound if-statement or two
> simple ones, the second one with an explanatory comment?

For my opinion, since you asked, the either case needs a comment on
top of that additional check.
Separate conditionals in independent cases are, of course, better.
Though, here they are dependent (as I read from commit message).
So, _personally_ I would go with compound one, but note first sentence
in this response.

-- 
With Best Regards,
Andy Shevchenko