lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 29 Aug 2017 19:57:19 +0100
From:   Mark Brown <>
To:     Fabrice Gasnier <>
Subject: Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf

On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote:

> +	ret = clk_prepare_enable(priv->clk);
> +	if (ret) {
> +		dev_err(&pdev->dev, "clk prepare failed\n");

If you're printing an error include the error code, it'll help users
figure out what went wrong.

> +	dev_info(&pdev->dev, "STM32 VREFBUF initialized\n");

This is just noise, remove it.

> +static int __init stm32_vrefbuf_init(void)
> +{
> +	return platform_driver_register(&stm32_vrefbuf_driver);
> +}
> +subsys_initcall(stm32_vrefbuf_init);

Why is this at subsys_initcall()?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists