linux-kernel - Re: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170829190015.kpscn3uuwbvwlp6e@sirena.org.uk>
Date:   Tue, 29 Aug 2017 20:00:15 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Ryan Lee <ryans.lee@...imintegrated.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        kuninori.morimoto.gx@...esas.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, ryan.lee.maxim@...il.com
Subject: Re: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B
 format

On Mon, Aug 28, 2017 at 04:30:53PM -0700, Ryan Lee wrote:

> +	if ((max98927->iface == SND_SOC_DAIFMT_DSP_A) ||
> +	    (max98927->iface == SND_SOC_DAIFMT_DSP_B))
> +		return 0;
> +
> +	/* BCLK configuration */

Why do we not configure the BCLK in DSP modes?  That's unusual and seems
likely to break some systems that rely on exact clocking.

Also if we're selecting on format a switch statement is generally better
to make any further special casing easier in future.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)