lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 31 Aug 2017 12:43:57 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Ryan Lee <ryans.lee@...imintegrated.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        kuninori.morimoto.gx@...esas.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, ryan.lee.maxim@...il.com
Subject: Re: [PATCH 2/9] ASoC: max98927: Added controls for Envelope tracking

On Mon, Aug 28, 2017 at 04:30:54PM -0700, Ryan Lee wrote:

>  	/* Envelope Tracking configuration */
>  	regmap_write(max98927->regmap,
>  		MAX98927_R0082_ENV_TRACK_VOUT_HEADROOM,
> -		0x08);
> +		0x0A);
>  	regmap_write(max98927->regmap,
>  		MAX98927_R0086_ENV_TRACK_CTRL,
>  		0x01);
> -	regmap_write(max98927->regmap,
> -		MAX98927_R0087_ENV_TRACK_BOOST_VOUT_READ,
> -		0x10);

Why are we changing the defaults here?  It was understandable to have a
fixed default that differed from the chip value when there was no
control but now there is a control and we're changing the default again
for some undocumented reason.  It'd be better to leave the values here
to avoid breaking compatibility with existing users and let users who
need different values change things using the newly added controls.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists