lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Wed, 30 Aug 2017 18:42:55 +0100
From:   Colin King <colin.king@...onical.com>
To:     Alessandro Rubini <rubini@...dd.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] drivers/fmc: make structure fmc_dbgfs_sdb_dump static and include fmc-private.h

From: Colin Ian King <colin.king@...onical.com>

The structure fmc_dbgfs_sdb_dump is local to the source and does not
need to be in global scope, so make it static.  Also, fmc-private.h
should be included to fix up two sparse warnings on fmc_debug_init
and fmc_debug_exit.

Cleans up sparse warnings:
symbol 'fmc_dbgfs_sdb_dump' was not declared. Should it be static?
symbol 'fmc_debug_init' was not declared. Should it be static?
symbol 'fmc_debug_exit' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/fmc/fmc-debug.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
index 32930722770c..06c43c1e8899 100644
--- a/drivers/fmc/fmc-debug.c
+++ b/drivers/fmc/fmc-debug.c
@@ -17,6 +17,8 @@
 #include <linux/sdb.h>
 #include <linux/fmc-sdb.h>
 
+#include "fmc-private.h"
+
 #define FMC_DBG_SDB_DUMP "dump_sdb"
 
 static char *__strip_trailing_space(char *buf, char *str, int len)
@@ -140,7 +142,7 @@ static int fmc_sdb_dump_open(struct inode *inode, struct file *file)
 }
 
 
-const struct file_operations fmc_dbgfs_sdb_dump = {
+static const struct file_operations fmc_dbgfs_sdb_dump = {
 	.owner = THIS_MODULE,
 	.open  = fmc_sdb_dump_open,
 	.read = seq_read,
-- 
2.14.1

Powered by blists - more mailing lists