lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 30 Aug 2017 19:46:55 +0200
From:   Borislav Petkov <>
To:     Brijesh Singh <>
Cc:,,,,, Thomas Gleixner <>,
        Ingo Molnar <>,
        "H . Peter Anvin" <>,
        Andy Lutomirski <>,
        Tony Luck <>,
        Piotr Luc <>,
        Tom Lendacky <>,
        Fenghua Yu <>,
        Lu Baolu <>,
        Reza Arbab <>,
        David Howells <>,
        Matt Fleming <>,
        "Kirill A . Shutemov" <>,
        Laura Abbott <>,
        Ard Biesheuvel <>,
        Andrew Morton <>,
        Eric Biederman <>,
        Benjamin Herrenschmidt <>,
        Paul Mackerras <>,
        Konrad Rzeszutek Wilk <>,
        Jonathan Corbet <>,
        Dave Airlie <>,
        Kees Cook <>,
        Paolo Bonzini <>,
        Radim Krčmář <>,
        Arnd Bergmann <>, Tejun Heo <>,
        Christoph Lameter <>
Subject: Re: [RFC Part1 PATCH v3 16/17] X86/KVM: Provide support to create
 Guest and HV shared per-CPU variables

On Wed, Aug 30, 2017 at 11:18:42AM -0500, Brijesh Singh wrote:
> I was trying to avoid mixing early and no-early set_memory_decrypted() but if
> feedback is: use early_set_memory_decrypted() only if its required otherwise
> use set_memory_decrypted() then I can improve the logic in next rev. thanks

Yes, I think you should use the early versions when you're, well,
*early* :-) But get rid of that for_each_possible_cpu() and do it only
on the current CPU, as this is a per-CPU path anyway. If you need to
do it on *every* CPU and very early, then you need a separate function
which is called in kvm_smp_prepare_boot_cpu() as there you're pre-SMP.



SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

Powered by blists - more mailing lists