linux-kernel - Re: [PATCH v6 4/4] x86/tsc: use tsc early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170830212144.GA48728@linux.intel.com>
Date:   Wed, 30 Aug 2017 14:21:44 -0700
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Pavel Tatashin <pasha.tatashin@...cle.com>
Cc:     linux@...linux.org.uk, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, john.stultz@...aro.org,
        sboyd@...eaurora.org, pasha.tatashin@...cle.com, x86@...nel.org,
        linux-kernel@...r.kernel.org, mingo@...hat.com,
        peterz@...radead.org, tglx@...utronix.de, hpa@...or.com,
        douly.fnst@...fujitsu.com
Subject: Re: [PATCH v6 4/4] x86/tsc: use tsc early

On Wed, Aug 30, 2017 at 02:12:09PM -0700, Fenghua Yu wrote:
> +static struct cyc2ns_data  cyc2ns_early;
> +static bool sched_clock_early_enabled;

Should these two varaibles be "__initdata"?

> +u64 sched_clock_early(void)
This function is only called during boot time. Should it
be a "__init" function?

Thanks.

-Fenghua