linux-kernel - Re: [PATCH v6 4/4] x86/tsc: use tsc early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9adbba2-5458-2035-789d-75a1def7cc92@oracle.com>
Date:   Wed, 30 Aug 2017 17:32:36 -0400
From:   Pasha Tatashin <pasha.tatashin@...cle.com>
To:     Fenghua Yu <fenghua.yu@...el.com>
Cc:     linux@...linux.org.uk, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, john.stultz@...aro.org,
        sboyd@...eaurora.org, x86@...nel.org, linux-kernel@...r.kernel.org,
        mingo@...hat.com, peterz@...radead.org, tglx@...utronix.de,
        hpa@...or.com, douly.fnst@...fujitsu.com
Subject: Re: [PATCH v6 4/4] x86/tsc: use tsc early

Hi Fenghua,

Thank you for looking at this. Unfortunately I can't mark either of them 
__init because sched_clock_early() is called from
	u64 sched_clock_cpu(int cpu)

Which is around for the live of the system.

Thank you,
Pasha

On 08/30/2017 05:21 PM, Fenghua Yu wrote:
> On Wed, Aug 30, 2017 at 02:12:09PM -0700, Fenghua Yu wrote:
>> +static struct cyc2ns_data  cyc2ns_early;
>> +static bool sched_clock_early_enabled;
> 
> Should these two varaibles be "__initdata"?
> 
>> +u64 sched_clock_early(void)
> This function is only called during boot time. Should it
> be a "__init" function?
> 
> Thanks.
> 
> -Fenghua
>