linux-kernel - Re: [PATCH v2 2/2] ARM: dts: rockchip: Add rk3288 vyasa board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Aug 2017 16:04:21 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jagan Teki <jagannadh.teki@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Heiko Stuebner <heiko@...ech.de>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Michael Trimarchi <michael@...rulasolutions.com>,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Jagan Teki <jagan@...rulasolutions.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: rockchip: Add rk3288 vyasa board

On Sat, Aug 26, 2017 at 03:39:24PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@...rulasolutions.com>
> 
> This patch adds initial support for rk3288 based
> Vyasa board, which is made by Amarula Solutions.
> 
> Signed-off-by: Jagan Teki <jagan@...rulasolutions.com>
> ---
> Changes for v2:
> - Added entry in Documentation/devicetree/bindings/arm/rockchip.txt
> 
>  Documentation/devicetree/bindings/arm/rockchip.txt |   4 +
>  arch/arm/boot/dts/Makefile                         |   3 +-
>  arch/arm/boot/dts/rk3288-vyasa.dts                 | 312 +++++++++++++++++++++
>  3 files changed, 318 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/rk3288-vyasa.dts

Acked-by: Rob Herring <robh@...nel.org>

I assume the regulator node names are consistent with other platforms, 
but at some point please fix them to be lowercase and not use '_'. IOW, 
build the dtbs with "W=2" and fix the warnings.

Rob