linux-kernel - Re: [PATCH v2 2/2] ARM: dts: rockchip: Add rk3288 vyasa board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD6G_RSR35sX2x8xpdht0XUbnjeEBML9bxwCqtHYC7oM5fazEA@mail.gmail.com>
Date:   Fri, 1 Sep 2017 22:36:08 +0530
From:   Jagan Teki <jagannadh.teki@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Michael Trimarchi <michael@...rulasolutions.com>,
        linux-rockchip@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Jagan Teki <jagan@...rulasolutions.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: rockchip: Add rk3288 vyasa board

On Fri, Sep 1, 2017 at 2:34 AM, Rob Herring <robh@...nel.org> wrote:
> On Sat, Aug 26, 2017 at 03:39:24PM +0530, Jagan Teki wrote:
>> From: Jagan Teki <jagan@...rulasolutions.com>
>>
>> This patch adds initial support for rk3288 based
>> Vyasa board, which is made by Amarula Solutions.
>>
>> Signed-off-by: Jagan Teki <jagan@...rulasolutions.com>
>> ---
>> Changes for v2:
>> - Added entry in Documentation/devicetree/bindings/arm/rockchip.txt
>>
>>  Documentation/devicetree/bindings/arm/rockchip.txt |   4 +
>>  arch/arm/boot/dts/Makefile                         |   3 +-
>>  arch/arm/boot/dts/rk3288-vyasa.dts                 | 312 +++++++++++++++++++++
>>  3 files changed, 318 insertions(+), 1 deletion(-)
>>  create mode 100644 arch/arm/boot/dts/rk3288-vyasa.dts
>
> Acked-by: Rob Herring <robh@...nel.org>
>
> I assume the regulator node names are consistent with other platforms,
> but at some point please fix them to be lowercase and not use '_'. IOW,
> build the dtbs with "W=2" and fix the warnings.

Out-off these [1], only /i2c@...50000 and  /memory are related to this
dts and these are consistent across rk3288 dts node name, so there is
nothing that I can fix here. If not please let me know if you find
any.

[1] https://paste.ubuntu.com/25445917/

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.