linux-kernel - Re: Converting struct timer_list callback argument to struct timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1709011219590.1857@nanos>
Date:   Fri, 1 Sep 2017 12:21:46 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Christoph Hellwig <hch@...radead.org>
cc:     Kees Cook <keescook@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: Converting struct timer_list callback argument to struct timer_list
 *

On Fri, 1 Sep 2017, Christoph Hellwig wrote:

> Good work!
> 
> I just think that the TIMER_CONTAINER name is revolting.
> 
> The usual name for such a helper fitting other uses like lists
> and rbtrees would be timer_entry, and that also reads much better.

I think the plan is to remove that thing afterward, because then the
callback function is:

	 void func(struct timer_list *timer)

So I don't mind the ugly name as it should be simply removed once the tree
is converted over.

Thanks,

	tglx