linux-kernel - RE: [PATCH 1/4] phy: rcar-gen3-usb2: check dr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SG2PR06MB0981D9D229370B1A6DAD241DD8920@SG2PR06MB0981.apcprd06.prod.outlook.com>
Date:   Fri, 1 Sep 2017 02:43:29 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "kishon@...com" <kishon@...com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

Hello,

> -----Original Message-----
> From: Sergei Shtylyov
> Sent: Thursday, August 31, 2017 6:41 PM
> 
> Hello!
> 
> On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote:
> 
> > The previous code assumed a channel has otg capability if a channel
> > has interrupt property. But, it is not good because:
> >   - Battery charging feature also needs interrupt property.
> >   - Some R-Car Gen3 SoCs (e.g. R-Car D3) doesn't have OTG capability.
> 
>     Don't.

Thank you for the point. I will revise it.

Best regards,
Yoshihiro Shimoda

> > So, this patch checks whether usb 2.0 host node has dr_mode property or
> > not. If it has 'dr_mode = "otg";', this driver enables otg capability.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> [...]
> 
> MBR, Sergei