linux-kernel - Re: [PATCH 2/2] iommu/omap: Add support to program multiple iommus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170901163312.GM19533@8bytes.org>
Date:   Fri, 1 Sep 2017 18:33:12 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     Suman Anna <s-anna@...com>
Cc:     iommu@...ts.linux-foundation.org, Tony Lindgren <tony@...mide.com>,
        Tero Kristo <t-kristo@...com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] iommu/omap: Add support to program multiple iommus

Hi Suman,
On Fri, Sep 01, 2017 at 11:21:45AM -0500, Suman Anna wrote:
> It's primarily a question of whether each iommu platform device need to
> be represented as a unique iommu_device or not. If you still think that
> both these need to be presented to iommu core as one device, I would
> have to add some glue logic in probe to tie the two devices together.

I think that you should only call iommu_device_register and friends for
the mmu-device you link the other devices against in .add_device.
Otherwise people will see two mmus in sysfs, one of them with no devices
behind it. That is inconsistent with the rest of the patch-set, which
basically handles bots mmus as one. But changing that should be easy, I
think.

Regards,

	Joerg