linux-kernel - Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170904121839.2hkk4anngjjo2ywl@sirena.org.uk>
Date:   Mon, 4 Sep 2017 13:18:39 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Arnaud Pouliquen <arnaud.pouliquen@...com>
Cc:     Lin Huang <hl@...k-chips.com>,
        "dgreif@...omium.org" <dgreif@...omium.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "briannorris@...omium.org" <briannorris@...omium.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "mka@...omium.org" <mka@...omium.org>,
        "dianders@...omium.org" <dianders@...omium.org>
Subject: Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start
 and stop

On Mon, Sep 04, 2017 at 12:03:21PM +0200, Arnaud Pouliquen wrote:

> > +static const struct snd_soc_dai_ops dmic_dai_ops = {
> > +	.trigger	= dmic_daiops_trigger,
> > +};

> should it be handle by trigger or DAPM?

DAPM is a bit better, yes.  I don't think it matters *overly* much in
this case where there's nothing else going on with the device, though
bypass use cases would need it.  OTOH it could mess up the timing.  I
was on the edge with this one but I decided that if it ends up making
a problem the binding is fine and the code can be sorted later.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)