linux-kernel - Re: [RFC v2 6/6] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170905073849.eeeo3kbncozzer46@dell>
Date:   Tue, 5 Sep 2017 08:38:49 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     sathyanarayanan.kuppuswamy@...ux.intel.com
Cc:     souvik.k.chakravarty@...el.com, x86@...nel.org, mingo@...hat.com,
        qipeng.zha@...el.com, hpa@...or.com, dvhart@...radead.org,
        tglx@...utronix.de, andy@...radead.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        sathyaosid@...il.com
Subject: Re: [RFC v2 6/6] platform/x86: intel_pmc_ipc: Use generic Intel IPC
 device calls

On Sat, 02 Sep 2017, sathyanarayanan.kuppuswamy@...ux.intel.com wrote:

> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> 
> Removed redundant IPC helper functions and refactored the driver to use
> generic IPC device driver APIs.
> 
> This patch also cleans-up PMC IPC user drivers to use APIs provided
> by generic IPC driver.
> 
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
> ---
>  arch/x86/include/asm/intel_pmc_ipc.h          |  37 +--

>  drivers/mfd/intel_soc_pmic_bxtwc.c            |  24 +-
>  include/linux/mfd/intel_soc_pmic.h            |   2 +

I'm a bit concerned by the API.  Any reason why you're not using
pointers for addresses?  And for the arguments where you are using
pointers, you should be using NULL, instead of 0.

>  drivers/platform/x86/intel_pmc_ipc.c          | 364 +++++++++-----------------
>  drivers/platform/x86/intel_telemetry_pltdrv.c | 114 ++++----
>  5 files changed, 215 insertions(+), 326 deletions(-)
> 
> Changes since v1:
>  * Removed custom APIs.
>  * Cleaned up PMC IPC user drivers to use APIs provided by generic
>    IPC driver.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog